Remove fraud review pending and rejection fields#8294
Merged
Conversation
changelog: Identity Verification, Internal, Remove unused fraud state fields
kbighorse
requested review from
zachmargolis
and removed request for
eric-gade and
theabrad
spec/models/profile_spec.rb
Outdated
Comment on lines
+407
to
+408
| expect(profile.fraud_review_pending?) | ||
| expect(profile.fraud_rejection?) |
Contributor
There was a problem hiding this comment.
This syntax was surprising to me, so I tried it out. Rspec doesn't check the result at all, since profile.fraud_rejection? returns false and the test passes. This needs to change in all the other tests with similar syntax too.
Suggested change
| expect(profile.fraud_review_pending?) | |
| expect(profile.fraud_rejection?) | |
| expect(profile.fraud_review_pending?).to eq(true) | |
| expect(profile.fraud_rejection?).to eq(false) |
Contributor
Author
There was a problem hiding this comment.
Whoa good catch thanks!
Contributor
Author
|
Yes the backfill was performed previously. I will link it in the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Identity Verification, Internal, Remove unused fraud state fields
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-9400
🛠 Summary of changes
This PR ignores and removes
fraud_review_pendingandfraud_rejectionboolean columns in the application code. Columns will be removed from the database in a subsequent PR.Data was backfilled by #8237
Blocking database columns drop