Rename spec "javascripts" folder to align to app "javascript"

[aduth]

🛠 Summary of changes

Renames spec/javascripts to spec/javascript, based on assumed convention that the app and spec folder structures are meant to align.

Before:

app/
  - javascript
spec/
  - javascripts

After:

app/
  - javascript
spec/
  - javascript

📜 Testing Plan

yarn test

[zachmargolis]

LGTM, but probably want to update package.json to only use the singular path right?

-    "test": "mocha 'spec/javascripts/**/**spec.+(j|t)s?(x)' 'app/javascript/packages/**/*.spec.+(j|t)s?(x)'",
+    "test": "mocha 'spec/javascript/**/**spec.+(j|t)s?(x)' 'app/javascript/packages/**/*.spec.+(j|t)s?(x)'",

[aduth]

LGTM, but probably want to update package.json to only use the singular path right?

Ah, yes indeed, that could have been bad 😅 I'll do a pass at any other references that might exist.

[aduth]

LGTM, but probably want to update package.json to only use the singular path right?

Ah, yes indeed, that could have been bad 😅 I'll do a pass at any other references that might exist.

Updated in c822739.