Conversation
Are we planning to do that as part of this pull request? Can we just use the main page heading content, which is pretty conventional/best practice, and how the other titles were decided upon? |
There was a problem hiding this comment.
Is probably why the build is failing, but I assume this should be using the page_title member and not image_path. Same note below.
| subject { presenter.image_path } | |
| subject { presenter.page_title } |
There was a problem hiding this comment.
Minor: Shouldn't need the \ ?
| expect(view).to receive(:title).with( \ | |
| expect(view).to receive(:title).with( |
d22219a to
f2966a0
Compare
|
Can we make sure we add a changelog when this is merged, I think this is a bug fix that's worth highlighting. |
|
im surprised its passing the check without a changelog. |
f2966a0 to
9099e82
Compare
Added |
[skip changelog]
changelog: Bug Fixes, Authentication, Fix page titles on backup codes and webauthn setup pages
9099e82 to
0444c3a
Compare
LG-9390
Changes titles for Webauthn setup page and backup code setup page. Note, the title for Webauthn Platform is still incorrect and is awaiting copy.