Skip to content

LG-9390: Add page titles#8266

Merged
jc-gsa merged 3 commits intomainfrom
LG-9390-page-titles
Apr 28, 2023
Merged

LG-9390: Add page titles#8266
jc-gsa merged 3 commits intomainfrom
LG-9390-page-titles

Conversation

@jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented Apr 24, 2023

LG-9390

Changes titles for Webauthn setup page and backup code setup page. Note, the title for Webauthn Platform is still incorrect and is awaiting copy.

@aduth
Copy link
Contributor

aduth commented Apr 25, 2023

Note, the title for Webauthn Platform is still incorrect and is awaiting copy.

Are we planning to do that as part of this pull request?

Can we just use the main page heading content, which is pretty conventional/best practice, and how the other titles were decided upon?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is probably why the build is failing, but I assume this should be using the page_title member and not image_path. Same note below.

Suggested change
subject { presenter.image_path }
subject { presenter.page_title }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Shouldn't need the \ ?

Suggested change
expect(view).to receive(:title).with( \
expect(view).to receive(:title).with(

@jc-gsa jc-gsa force-pushed the LG-9390-page-titles branch from d22219a to f2966a0 Compare April 25, 2023 16:10
@aduth
Copy link
Contributor

aduth commented Apr 25, 2023

Can we make sure we add a changelog when this is merged, I think this is a bug fix that's worth highlighting.

@mdiarra3
Copy link
Contributor

im surprised its passing the check without a changelog.

@jc-gsa jc-gsa force-pushed the LG-9390-page-titles branch from f2966a0 to 9099e82 Compare April 25, 2023 20:04
@jc-gsa
Copy link
Contributor Author

jc-gsa commented Apr 25, 2023

Can we make sure we add a changelog when this is merged, I think this is a bug fix that's worth highlighting.

Added

jc-gsa added 3 commits April 28, 2023 11:50
[skip changelog]
changelog: Bug Fixes, Authentication, Fix page titles on backup codes and webauthn setup pages
@jc-gsa jc-gsa force-pushed the LG-9390-page-titles branch from 9099e82 to 0444c3a Compare April 28, 2023 16:51
@jc-gsa jc-gsa merged commit 5474156 into main Apr 28, 2023
@jc-gsa jc-gsa deleted the LG-9390-page-titles branch April 28, 2023 17:11
@mdiarra3 mdiarra3 mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants