Switch to using constants for auth_method values#8315
Merged
mitchellhenke merged 3 commits intomainfrom May 1, 2023
Merged
Conversation
changelog: Internal, Maintenance, Switch to using constants for auth_method values
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/constant-auth-method-values
branch
from
d3cd7ce to
a4ebf5f
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Inspired by @zachmargolis' comment here to move away from copying different strings everywhere, this PR defines and uses constants for assigning and checking values in the session's
auth_methodso that we can more easily continue to develop around these pieces of functionality.This PR should be neutral in terms of behavior.