LG-9494 capture complete checks if previous step is done#8309
Merged
soniaconnolly merged 5 commits intomainfrom May 1, 2023
Merged
Conversation
Check that DocumentCapture completed successfully. Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
Check result before redirecting in DocumentCaptureController
We're not using async, and it causes failures due to missing data in DocumentCaptureControllers
changelog: Internal, Flow State Machine replacement, redirect as needed within document capture hybrid flow
matthinz
approved these changes
Apr 28, 2023
soniaconnolly
changed the title
jmhooper
approved these changes
May 1, 2023
soniaconnolly
deleted the
sonia-lg-9494-capture-complete-checks-if-prevous-step-is-done
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LG-9494
🛠 Summary of changes
Add before action to CaptureCompleteController to redirect if DocumentCapture step was not successful, in the hybrid flow. Also in DocumentCapture#show, redirect to CaptureComplete if document capture is already done.
Set aysnc to false in hybrid flow feature specs.
Note: Do we want/need to check if document capture was successful before leaving DocumentCaptureController#update, or do we rely on the following controller (CaptureComplete or Ssn) to redirect backwards when needed?
📜 Testing Plan
Provide a checklist of steps to confirm the changes.