Rename "signed_up" spec trait to "fully_registered"#8302
Merged
Conversation
changelog: Internal, Code Quality, Clarify name for fully-registered test accounts
zachmargolis
approved these changes
Apr 27, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, wow I didn't realize we used this trait so much! very glad we broke out into a separate PR
Comment on lines
-26
to
+32
| :user, :signed_up, otp_delivery_preference: delivery_preference, | ||
| direct_otp_sent_at: direct_otp_sent_at, | ||
| with: { phone: '+1 (703) 555-0000' } | ||
| :user, | ||
| :fully_registered, | ||
| otp_delivery_preference: delivery_preference, | ||
| direct_otp_sent_at: direct_otp_sent_at, | ||
| with: { phone: '+1 (703) 555-0000' }, |
Contributor
There was a problem hiding this comment.
big fan of reflowing these. thank you!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Renames the User spec factory
signed_uptrait tofully_registered, to improve clarity that this reflects a user who has completed all of (a) submitting their email address, (b) confirming their email address, and (c) adding a multi-factor authentication method. This also improves consistency with the newUser#fully_registered?method and theregistration_logstable'sregistered_atfield.See: https://github.com/18F/identity-idp/pull/8270/files#r1176848052
📜 Testing Plan