Merged
Conversation
* Revert "Revert "Add view component previews using Lookbook" (#6004)" This reverts commit e7ff579. * Add changelog changelog: Internal, Component Preview, Add development preview environment for UI components * Move Lookbook/ViewComponent preview config to application.rb For future support in deployed environments * Add additional button variations * Fix border-box bug * Render default and component JavaScripts * Add Accordion component preview * Add Barcode component preview * Add Block Link component preview * Use custom preview controller for synchronous script enqueues * Add Clipboard Button component preview * Try handling CSP overrides in preview controller * Revert to referencing CSP from request Because current_content_security_policy will not be nil, even if empty * Add countdown component preview * Add icon component preview * Add basic theming configuration for Lookbook * Update Lookbook and remove workaround for now-fixed bug * Revert (back) to current_content_security_policy Address previous issues by checking env in the same way that Lookbook does https://github.com/allmarkedup/lookbook/blob/b40f6ea42296be4d5eec9c5d858c4b11f878451c/app/controllers/lookbook/application_controller.rb#L3-L5 * Set X-Frame-Options based on component preview config * Manage component CSP with Rack middleware * Fix download button space encoding * Add preview for DownloadButton component * Temporary: Remove mounting Theory is something in the engine init is messing with the tests? Shouldn't be mounted tho, based on feature flag * Revert "Temporary: Remove mounting" This reverts commit cf2fff9. * Upgrade Lookbook to latest * Try loading on demand * Require at config * Fix standalone MemorableDateComponent missing dependencies * Add MemorableDateComponent component preview * Add PasswordToggleComponent component preview * Add PhoneInputComponent component preview * Add SpinnerButtonComponent component preview * Add StatusPageComponent component preview * Add StepIndicatorComponent component preview * Add TimeComponent component preview * Add TroubleshootingOptionsComponent component preview * Add ValidatedFieldComponent component preview * Swap "Kitchen Sink" and "Playground" with "Preview" and "Workbench" * Move Lookbook gem back into alphabetized list See: #7115 (comment)
* Refactor service provider services and forms into mixins InheritedProofingConcern refactored to lift IP Service Provider-specific API service code and IP Service Provider-specific Form code to their own mixins so that code that does not have direct access to session, can use SP-specific services and forms. changelog: Internal, Inherited Proofing, Refactor Service Provider services and forms * Add SP-agnostic #inherited_proofing? * Address PR feedback * Fix broken specs
* Fix typo in spec name for localization linter * Update MailLaterLinter to check only UserMailer - ReportMailer gets deliver_now [skip changelog]
**Why**: To assist in future key rotations changelog: Internal, Attempts API, Add "kid" header claim to assist in key rotation
Changelog: Internal, Email, Only check email for sensitive info when async
* Add API call to "we are retrieving" page (7255) Why: Inherited proofing users want a logical place in the flow to retrieve their data changelog: Internal, Inherited Proofing, We are Retrieving API call async state doesn't work async works * Move mark step complete out of module * Add additional comments for error path * Refactoring saving work saving work * Service Provider-agnostic Inherited Proofing services ...so that we can obtain Service Provider-agnostic Inherited Proofing services in request/response-related code and in other code that does not have direct access to Session. * Job works, refactoring async saving work saving work Bug fix and clean up * Fixing spec support * Additional clean up * Changed perform now to later * Formatting change * Remove unused include * Formatting and removing unused calls * Better refactoring * Add existing session check * Linting * Transition to new service files * Remove unneeded files Co-authored-by: gangelo <web.gma@gmail.com>
[skip changelog]
**Why**: we avoid loading lookbook gem unless the feature flag is on, so the classes to subclass and the mixins will fail due to load errors [skip changelog] Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Remove concurrency limits from scheduled cron jobs in GoodJob changelog: Internal, GoodJob, Remove concurrency limits from scheduled cron jobs in GoodJob * fix specs
* Update GoodJob and GoodJob configuration changelog: Internal, Dependencies, Update GoodJob and GoodJob configuration * add configuration for good job queue select limit
…revent logging failures (#7202) * Ensure job class defines warning_error_classes before calling it changelog: Bug Fixes, Emails, Ensure job class defines warning_error_classes before calling it * Update lib/identity_job_log_subscriber.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * add spec Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Our dev docs have a sample YAML file which does not include a state ID number. As a result when partners change the jurisdiction to a supported jurisdiction it causes failures when calling downcase on the nil value. This commit fixes this bug by protecting against a nil value there. We should also add a state id number and type to the example YAML on the dev docs. [skip changelog]
We are retiring IAL2-strict which means we will no longer be asking the React app to collect selfies from the user. This commit sets the flags to be permanently false so we can start working back and removing code to remove the request for selfies. [skip changelog]
* update string trnaslations to reflect new content * update translations * Improvements, Content, update user guidance
**Why**: Lets us link to specific definition of code, as well as link to searching for usages of where it's called [skip changelog]
mitchellhenke
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal