LG-7891 Protect against nil state id numbers in mock proofer#7205
Merged
julialeague merged 1 commit intomainfrom Oct 24, 2022
Merged
LG-7891 Protect against nil state id numbers in mock proofer#7205julialeague merged 1 commit intomainfrom
julialeague merged 1 commit intomainfrom
Conversation
Our dev docs have a sample YAML file which does not include a state ID number. As a result when partners change the jurisdiction to a supported jurisdiction it causes failures when calling downcase on the nil value. This commit fixes this bug by protecting against a nil value there. We should also add a state id number and type to the example YAML on the dev docs. [skip changelog]
julialeague
approved these changes
Oct 24, 2022
Contributor
julialeague
left a comment
julialeague
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
aduth
approved these changes
Oct 24, 2022
jmhooper
added a commit
to GSA-TTS/identity-dev-docs
that referenced
this pull request
Oct 24, 2022
These values are used by the state ID mock proofer. This commit adds them both for visibility and to prevent their absence from causing problems (e.g. 18F/identity-idp#7205)
Contributor
Author
|
Documentation added here: GSA-TTS/identity-dev-docs#281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our dev docs have a sample YAML file which does not include a state ID number. As a result when partners change the jurisdiction to a supported jurisdiction it causes failures when calling downcase on the nil value.
This commit fixes this bug by protecting against a nil value there. We should also add a state id number and type to the example YAML on the dev docs.
[skip changelog]