LG 7255 - Add API call to "we are retrieving" page#7149
Conversation
holytoastr
added
the
inherited proofing
app/services/idv/steps/inherited_proofing/user_pii_managable.rb
Outdated
Show resolved
Hide resolved
app/services/idv/steps/inherited_proofing/verify_wait_step_show.rb
Outdated
Show resolved
Hide resolved
app/services/idv/steps/inherited_proofing/verify_wait_step_show.rb
Outdated
Show resolved
Hide resolved
app/services/idv/steps/inherited_proofing/verify_wait_step_show.rb
Outdated
Show resolved
Hide resolved
app/services/idv/steps/inherited_proofing/verify_wait_step_show.rb
Outdated
Show resolved
Hide resolved
Why: Inherited proofing users want a logical place in the flow to retrieve their data changelog: Internal, Inherited Proofing, We are Retrieving API call async state doesn't work async works
saving work saving work
services ...so that we can obtain Service Provider-agnostic Inherited Proofing services in request/response-related code and in other code that does not have direct access to Session.
saving work saving work Bug fix and clean up
holytoastr
force-pushed
the
lg-7255-we-are-retrieving-call
branch
from
3392ffc to
282a50c
Compare
app/services/idv/steps/inherited_proofing/verify_wait_step_show.rb
Outdated
Show resolved
Hide resolved
| params.require(:inherited_proofing).permit(:ial2_consent_given) | ||
| end | ||
|
|
||
| def enqueue_job |
There was a problem hiding this comment.
We may have to deal with the case of a double submit here. Meaning if there is another job in progress we don't want to enqueue another one.
There was a problem hiding this comment.
Would we do that by first checking if the document capture session already exists?
There was a problem hiding this comment.
Yeah, something like that. Checking to see if there is a uuid in the session already. If there is looking up the job and making sure it is not in-progress
There was a problem hiding this comment.
Will do. Thanks for the feedback
|
@jmhooper @zachmargolis refactors based on your feedback in this PR; please have a look: #7181 |
|
Looks like #7181 is merged. I think we should be able to merge main into this one to clean it up |
|
@jmhooper Merged in. Need to make some adjustments to use the new code. |
4 participants
Add API call to "we are retrieving" page (7255)
Why:
Inherited proofing users want a logical place in the flow to retrieve their data
changelog: Internal, Inherited Proofing, We are Retrieving API call
🎫 Ticket
7255
🛠 Summary of changes
InheritedProofingConcernrefactored to lift IP Service Provider-specific API service code and IP Service Provider-specific Form code to their own method modules and Factories. This was done because code that does not have direct access to Session (in order to get the current Service Provider we are working with) still needs to access these services; for example, ActiveJob.