Add kid "key id" header claim to Attempts API JWEs#7189
Merged
zachmargolis merged 2 commits intomainfrom Oct 21, 2022
Merged
Conversation
**Why**: To assist in future key rotations
changelog: Internal, Attempts API, Add "kid" header claim to assist in key rotation
n1zyy
approved these changes
Oct 21, 2022
| zip: 'DEF', | ||
| alg: 'RSA-OAEP', | ||
| enc: 'A256GCM', | ||
| kid: JWT::JWK.new(event_data_encryption_key).kid, |
Contributor
There was a problem hiding this comment.
This will probably allow us to remove the irs_attempt_api_public_key_id parameter later: https://github.com/18F/identity-idp/blob/main/config/application.yml.default#L347
Though that's a breaking schema change so we should hold off.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
N/A
🛠 Summary of changes
Adds a Key ID header claim that is in plaintext in the resulting JWE, so it can assist in future key rotations
🚀 Notes for Deployment
Include any special instructions for deployment.