Revert "Add view component previews using Lookbook"#6004
Merged
Conversation
This reverts commit 869ec8a.
zachmargolis
approved these changes
Feb 25, 2022
Contributor
Author
1 task
aduth
added a commit
that referenced
this pull request
Oct 21, 2022
* Revert "Revert "Add view component previews using Lookbook" (#6004)" This reverts commit e7ff579. * Add changelog changelog: Internal, Component Preview, Add development preview environment for UI components * Move Lookbook/ViewComponent preview config to application.rb For future support in deployed environments * Add additional button variations * Fix border-box bug * Render default and component JavaScripts * Add Accordion component preview * Add Barcode component preview * Add Block Link component preview * Use custom preview controller for synchronous script enqueues * Add Clipboard Button component preview * Try handling CSP overrides in preview controller * Revert to referencing CSP from request Because current_content_security_policy will not be nil, even if empty * Add countdown component preview * Add icon component preview * Add basic theming configuration for Lookbook * Update Lookbook and remove workaround for now-fixed bug * Revert (back) to current_content_security_policy Address previous issues by checking env in the same way that Lookbook does https://github.com/allmarkedup/lookbook/blob/b40f6ea42296be4d5eec9c5d858c4b11f878451c/app/controllers/lookbook/application_controller.rb#L3-L5 * Set X-Frame-Options based on component preview config * Manage component CSP with Rack middleware * Fix download button space encoding * Add preview for DownloadButton component * Temporary: Remove mounting Theory is something in the engine init is messing with the tests? Shouldn't be mounted tho, based on feature flag * Revert "Temporary: Remove mounting" This reverts commit cf2fff9. * Upgrade Lookbook to latest * Try loading on demand * Require at config * Fix standalone MemorableDateComponent missing dependencies * Add MemorableDateComponent component preview * Add PasswordToggleComponent component preview * Add PhoneInputComponent component preview * Add SpinnerButtonComponent component preview * Add StatusPageComponent component preview * Add StepIndicatorComponent component preview * Add TimeComponent component preview * Add TroubleshootingOptionsComponent component preview * Add ValidatedFieldComponent component preview * Swap "Kitchen Sink" and "Playground" with "Preview" and "Workbench" * Move Lookbook gem back into alphabetized list See: #7115 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5982
In testing in sandbox environments, there are errors when server starts up.
Revert while we investigate further.