Update MailLaterLinter to only check UserMailer#7187
Merged
zachmargolis merged 3 commits intomainfrom Oct 21, 2022
Merged
Conversation
- ReportMailer gets deliver_now
zachmargolis
commented
Oct 21, 2022
Comment on lines
+23
to
+32
| receiver = node.children.first&.receiver | ||
| return if !receiver | ||
|
|
||
| mailer_name = if receiver.const_type? | ||
| # MailerClass.email.send_later | ||
| receiver.const_name | ||
| elsif receiver.method_name == :with | ||
| # MailerClass.with(...).email.send_later | ||
| receiver.receiver.const_name | ||
| end |
Contributor
Author
There was a problem hiding this comment.
another approach would be to get smarter about matching expressions... something like...
(send
(send
(send
(const nil :UserMailer) :with
$...) $...) :deliver_now)
where we have a regex capture for :deliver_now and also check :deliver_later
or maybe two regexes?
anyways this was something I could brute-force via specs
[skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
N/A
🛠 Summary of changes
Follow-up to #7155 (comment)
Basically,
ReportMailer.something.deliver_nowis fine, but we still want to ensure consistency forUserMailer