Merged
Conversation
changelog: Internal, Build Tooling, Upgrade stylesheet build dependencies
* changelog: Improvements, In-Person Proofing, Adjust approach to newline control CTA * Add minor comment
* LG-7606: firstcut at ViewComponent to generate key pairs * track the location where embedded, and embed in the sign in page * Only a configured percentage of users will generate keys * use ViewComponent conditional rendering * Changelog changelog: Internal, Metrics, collecting timing data for key pair generation Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from 3.19.4 to 3.21.7. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.19.4...v3.21.7) --- updated-dependencies: - dependency-name: google-protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Change fsm_ to floe_state_machine_ to eliminate the acronym [skip changelog] * Rename flow_state_machine_initialize To initialize_flow_state_machine
* Standardization clean-up (naming, alphabetizing) changelog: Internal, Attempts API, Standardize events
changelog: Internal, Analytics Events, Enhance linter to catch non-keyword arguments
* add failing spec * Add content indicating users will return to the service provider on logout confirmation page changelog: Improvements, OpenID Connect Logout, Add content indicating users will return to the service provider on logout confirmation page Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: Internal, Dependencies, Upgrade development dependencies
changelog: Bug Fixes, Identity Verification, Fix error when entering invalid characters for personal key
This commit is a follow-up to #7088. It creates a struct which handles results for all proofers. This helps prevent issues where the result objects for proofers get out of sync. [skip changelog]
We had issues where we were raising NoMethodErrors because the API between the proofer result objects had drifted. This commit helps to address that problem in the future by collapsing all of the state ID result objects into a single struct and building out the result in the proofer. [skip changelog]
* Use design system utility classes for IPP location elements changelog: Internal, Performance, Remove redundant stylesheet CSS * Increase margin * Remove break-word class 1. It doesn't have the same effect as wrap-name, which assigned the overflow-wrap style (whereas break-word assigns word-wrap) 2. Unclear what specific scenario it's meant to accommodate, since post office names would not be expected to include long words which couldn't break normally 3. `word-wrap: break` is deprecated and we should try to move away from it * Reassign full width for <tablet buttons There's a small viewport range between 480-640 which would otherwise show the button at a narrower width, due to default styles of USWDS showing button at full width only up to 480px viewport
* Add 'We are retrieving' page (LG-7254) Why: User needs to be notified that their data is being retrieved and be given an indicator on how long it could take changelog: Internal, Inherited Proofing, We are retrieving page * Adjust styling * Clean up * Update spec/views/idv/inherited_proofing/retrieval.html.erb_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Remove alt text from spinner Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Refactored UserSession context functions changelog: Internal, General, Refactored inconsistent function names * Update app/services/user_session_context.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * lint fixes Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Clarify name of email and password auth event changelog: Internal, Attempts API, Standardize events
…How Verifying" Page (#7091) * Make formatting consistent * Remove the VA IP call and associated functionality Removed the aforementioned from the "How Verifying" page. changelog: Improvements, Upcoming Features, Remove the VA IP Call and Associated Functionality From the "How Verifying" Page (LG-7447) * Remove .upcase on user pii per Ben * Remove unnecessary remote_identity_proofing * Make tests dependent upon va api call data pending
- Lets us mock better via stub_const, no need to reload the initializer [skip changelog]
zachmargolis
reviewed
Oct 6, 2022
| end | ||
|
|
||
| def render? | ||
| AbTests::KEY_PAIR_GENERATION.bucket(SecureRandom.uuid) == :key_pair_group |
Contributor
There was a problem hiding this comment.
wait this is just completely random? I guess we don't know which user at this point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.