Use a shared StateIdResult struct for all State ID proofer calls#7088
Merged
Use a shared StateIdResult struct for all State ID proofer calls#7088
Conversation
We had issues where we were raising NoMethodErrors because the API between the proofer result objects had drifted. This commit helps to address that problem in the future by collapsing all of the state ID result objects into a single struct and building out the result in the proofer.
jmhooper
added a commit
that referenced
this pull request
Oct 5, 2022
This commit is a follow-up to #7088. It creates a struct which handles results for all proofers. This helps prevent issues where the result objects for proofers get out of sync. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Oct 5, 2022
This commit is a follow-up to #7088. It creates a struct which handles results for all proofers. This helps prevent issues where the result objects for proofers get out of sync. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Oct 6, 2022
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
This commit is a follow-up to #7088. It creates a struct which handles results for all proofers. This helps prevent issues where the result objects for proofers get out of sync. [skip changelog]
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
We had issues where we were raising NoMethodErrors because the API between the proofer result objects had drifted. This commit helps to address that problem in the future by collapsing all of the state ID result objects into a single struct and building out the result in the proofer. [skip changelog]
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had issues where we were raising NoMethodErrors because the API between the proofer result objects had drifted. This commit helps to address that problem in the future by collapsing all of the state ID result objects into a single struct and building out the result in the proofer.