Use design system utility classes for IPP location elements#7036
Merged
Conversation
aduth
force-pushed
the
aduth-separator-button-margin
branch
from
9064bd0 to
50bfac4
Compare
changelog: Internal, Performance, Remove redundant stylesheet CSS
1. It doesn't have the same effect as wrap-name, which assigned the overflow-wrap style (whereas break-word assigns word-wrap) 2. Unclear what specific scenario it's meant to accommodate, since post office names would not be expected to include long words which couldn't break normally 3. `word-wrap: break` is deprecated and we should try to move away from it
There's a small viewport range between 480-640 which would otherwise show the button at a narrower width, due to default styles of USWDS showing button at full width only up to 480px viewport
aduth
force-pushed
the
aduth-separator-button-margin
branch
from
50bfac4 to
f3ea9d3
Compare
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Use design system utility classes for IPP location elements changelog: Internal, Performance, Remove redundant stylesheet CSS * Increase margin * Remove break-word class 1. It doesn't have the same effect as wrap-name, which assigned the overflow-wrap style (whereas break-word assigns word-wrap) 2. Unclear what specific scenario it's meant to accommodate, since post office names would not be expected to include long words which couldn't break normally 3. `word-wrap: break` is deprecated and we should try to move away from it * Reassign full width for <tablet buttons There's a small viewport range between 480-640 which would otherwise show the button at a narrower width, due to default styles of USWDS showing button at full width only up to 480px viewport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This pull request removes custom styles which had been implemented for the in-person proofing locations screen. Largely this should be visually identical to how it was previously, with the exception of a minor margin correction for the mobile button placement (based on Figma references).
Rationale:
Context:
📜 Testing Plan
👀 Screenshots
Desktop:
Before:
After:
Mobile:
Before:
After: