Conversation
Removed the aforementioned from the "How Verifying" page. changelog: Improvements, Upcoming Features, Remove the VA IP Call and Associated Functionality From the "How Verifying" Page (LG-7447)
gangelo
force-pushed
the
lg-7447-remove-the-va-ip-call-and-associated-functionality-from-the-how-verifying-page
branch
from
7212ae4 to
4a99792
Compare
gangelo
force-pushed
the
lg-7447-remove-the-va-ip-call-and-associated-functionality-from-the-how-verifying-page
branch
from
4a99792 to
91b3d46
Compare
jmhooper
approved these changes
Oct 6, 2022
gangelo
deleted the
lg-7447-remove-the-va-ip-call-and-associated-functionality-from-the-how-verifying-page
branch
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
…How Verifying" Page (#7091) * Make formatting consistent * Remove the VA IP call and associated functionality Removed the aforementioned from the "How Verifying" page. changelog: Improvements, Upcoming Features, Remove the VA IP Call and Associated Functionality From the "How Verifying" Page (LG-7447) * Remove .upcase on user pii per Ben * Remove unnecessary remote_identity_proofing * Make tests dependent upon va api call data pending
gangelo
added
the
inherited proofing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7447
🛠 Summary of changes
Remove the VA IP Call and Associated Functionality From the "How Verifying" Page. The VA IP call needs to be moved to accommodate the "We retrieving your information" view that must be displayed to the user while the call to the VA for user PII takes place (asynchronously).
Tests for the "verify your info" step/view that are dependent upon user PII in session, have been made "pending" until card LG-7255 is complete, marked with the following comment:
# LG-7255: Need to uncomment this test once this card is completed.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
N/A
🚀 Notes for Deployment
N/A