Use a shared struct for address proofing results#7097
Merged
Conversation
zachmargolis
approved these changes
Oct 5, 2022
| end | ||
|
|
||
| def parse_verification_errors(verification_response) | ||
| errors = Hash.new { |h, k| h[k] = [] } |
Contributor
Author
There was a problem hiding this comment.
you learn something new every day
| exception:, | ||
| vendor_name:, | ||
| transaction_id: '', | ||
| reference: '' |
Contributor
There was a problem hiding this comment.
maybe easier to default reference to nil than empty string?
Contributor
Author
There was a problem hiding this comment.
I was just trying to keep reference consistent with transaction_id
Contributor
Author
There was a problem hiding this comment.
I'm not sure I understand the reasoning for making it nil vs empty string? I think all we do is log it and the result is the same in the end, right?
Contributor
There was a problem hiding this comment.
I guess nil to me is a more real "isn't there" vs some sort of default from empty string, but you're right, for most situations they're the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a shared struct for the address proofer calls. This commits make sure that all of our adapters return a result with the same public API.
See also: #7088, #7092
[skip changelog]