Enhance analytics linter to catch non-keyword arguments#7053
Merged
Conversation
Contributor
Author
Error as expected in GitLab: https://gitlab.login.gov/lg/identity-idp/-/jobs/84884 |
changelog: Internal, Analytics Events, Enhance linter to catch non-keyword arguments
aduth
force-pushed
the
aduth-analytics-linter-positional-param
branch
from
5339bd9 to
8e18ade
Compare
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
changelog: Internal, Analytics Events, Enhance linter to catch non-keyword arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Analytics methods are expected to contain only keyword arguments and an
**extrasplat, so we should enforce this through the existing lint tooling.Related example: #7044
📜 Testing Plan
rspec spec/lib/analytics_events_documenter_spec.rbpassesmake lint_tracker_eventsfails as expected (until after Adjust email parameter declaration #7044 is merged)