Skip to content

build-sass: Upgrade dependencies#7082

Merged
aduth merged 1 commit intomainfrom
aduth-upgrade-sass
Oct 4, 2022
Merged

build-sass: Upgrade dependencies#7082
aduth merged 1 commit intomainfrom
aduth-upgrade-sass

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Oct 4, 2022

🛠 Summary of changes

Upgrades stylesheet build dependencies, in order to...

  • Ideally resolve recurring development environment issues with the missing Sass executable (related Slack comment) or missing lightningcss (né @parcel/css) dependency (related Slack comment)
  • Flatten dependency tree (observe removed lines) due to revised approach for Sass executable installation using optionalDependencies (related upstream change)
  • Avoid developer confusion related to renamed @parcel/css dependency

📜 Testing Plan

Observe no visual regressions or errors after compiling Sass and running the application:

yarn install
yarn clean
make run

@aduth
build-sass: Upgrade dependencies
7096c76 
changelog: Internal, Build Tooling, Upgrade stylesheet build dependencies
@aduth aduth requested review from eric-gade, gangelo and mmagsa October 4, 2022 13:49
eric-gade
eric-gade approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@aduth aduth merged commit f48d650 into main Oct 4, 2022
@aduth aduth deleted the aduth-upgrade-sass branch October 4, 2022 17:17
jskinne3 pushed a commit that referenced this pull request Oct 12, 2022
@aduth @jskinne3
build-sass: Upgrade dependencies (#7082)
a449b80 
changelog: Internal, Build Tooling, Upgrade stylesheet build dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchellhenke mitchellhenke mitchellhenke approved these changes

@gangelo gangelo Awaiting requested review from gangelo

@mmagsa mmagsa Awaiting requested review from mmagsa

+1 more reviewer

@eric-gade eric-gade eric-gade approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduth @mitchellhenke @eric-gade