Merged
Conversation
* Fix logging for password visibility toggle **Why**: Frontend event logging map is case sensitive, so the event was not being matched as expected. * Use same path as "visit" command changelog: Internal, Analytics, Add logging for password visibility toggle clicked * Add extra logging * Try fetch wrapper for awaiting analytics logging completion * Run teardown in ensure handler Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
) * Make sign-in page buttons big to improve consistency changelog: Improvements, Style, Make sign-in page buttons big to improve consistency * Update app/views/devise/sessions/new.html.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update app/views/devise/sessions/new.html.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Updating all warning icon images to new icon * Updating error icon * Adding personal-key icon Will need to update where it gets used, since this appears to be the first instance of the icon * Updating info-question icon * Replacing error-lock icon * Updating icon names and styling in templates/stylesheets -- What We have replaced half a dozen existing icons with new SVGs. These have different names in some cases, so the references need to be replaced in templates. Additionally, these icons require larger display sizes given their circular shape, so we need to find corresponding template tags and make sure they are given the correct dimensions (88x88px) changelog: Internal, Assets, updating icon images and references * Updating icon image dimensions in templates changelog: Internal, Assets, updating icon images and references * Updating remaining templates with new icons sizes changelog: Internal, Accessibility, updating icons * Updating SVG assets to not have inline styles changelog: Internal, Accessibility, updating accessible icons * Removing now unused image from assets changelog: Internal, Accessibility, updating to more accessible icons * Updating alt test for confirm delete account icon changelog: Internal, Accessibility, updating to more accessible icons * Fixing lints changelog: Internal, Accessibility, switching to more accessible icons * Adding localized alt text for new icons Also updating any corresponding templates to use the new localizations. changelog: Internal, Accessibility, updating to more accessible icons * Fixing es local yaml typo * Updating templates and modals to use new icon css changelog: Internal, Accessibility, adding more accessible icons * Updating status page component with new icon locales changelog: Internal, Accessibility, adding more accessible icons * Removing old icon css from _modal changelog: Internal, Accessibility, adding more accessible icons * Fixing dont have personal key modal styling changelog: Internal, Accessibility, adding more accessible icons * Update app/assets/stylesheets/components/_icon.scss Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Switching location of icon locales Was previously in `titles`, but moved to the more appropriate locales directory of `image_description` changelog: Internal, Accessibility, updating to more accessible icons * Changing lg-icon to alert-icon changelog: Internal, Accessibility, adding more accessible icons * Switching alert_icon to its own sass partial changelog: Internal, Accessibility, adding more accessible icons * Creating a new ViewComponent for alert icons changelog: Internal, Accessibility, adding more accessible icons * Creating new AlertIcon ViewComponent with tests Also updating the various templates to use the new ViewComponent changelog: Internal, Accessibility, adding more accessible icons * Ensuring frontend alert icons use the correct width/height changelog: Internal, Accessibility, adding more accessible icons * Fixing broken JS test i18n assumption changelog: Internal, Accessibility, adding more accessible icons * Updating sass partial for inclusion changelog: Internal, Accessibility, adding more accessible icons * Updating StatusPageComponent to use AlertIconComponent This eliminated insonsistencies between the way these two label and display the icon images that they share. changelog: Internal, Accessibility, adding more accessible icons * Removing unused locales changelog: Internal, Accessibility, adding more accessible icons * Update app/views/sign_up/registrations/_required_pii_accordion.html.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Ensuring that we raise an error if invalid icon_name is passed Also updating the signature of the initialization method changelog: Internal, Accessibility, adding more accessible icons * Updating views to use new AlertIconComponent initializer changelog: Internal, Accessibility, adding more accessible icons * Simplifying custom tag options for alt text changelog: Internal, Accessibility, adding more accessible icons * Ensure we are using symbols for icon names changelog: Internal, Accessibility, adding more accessible icons * Fixing initializer of AlertIconComponent changelog: Internal, Accessibility, adding more accessible icons * Moving personal key icon image to status Also updating and corresponding location references. changelog: Internal, Accessibility, adding more accessible icons * Removing redundant alert-icon class declaration changelog: Internal, Accessibility, adding more accessible icons * Restoring get-started accordion personal key image Also reverting to plain image_tag for the rendering, as with other sibling icon images in the partial changelog: Internal, Accessibility, adding more accessible icons * Accounting for possible size tag option in component template changelog: Internal, Accessibility, adding more accessible icons * Update app/components/alert_icon_component.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Fixing conflicting linter errors changelog: Internal, Accessibility, adding more accessible icons * Refactoring width, height, and size interplay We are also adding a couple of tests to ensure that AlertIconComponent is correctly handling the logic if width, height, and size attributes changelog: Internal, Accessibility, adding more accessible icons * Empty commit for gitlab CI changelog: Internal, Accessibility, adding more accessible icons * Cleaning up tests changelog: Internal, Accessibility, adding more accessible icons * Removing casing for size option It's not currently being used, so we are removing any handling of this option changelog: Internal, Accessibility, adding more accessible icons Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
…or now (#7025) * changelog: Improvements, Authentication, Update from cancel to skip for now * update spec * remove unneeded class
* change hint element from span to div * add aria-describedby to hint so example read when screen reader gets to input field * fix lint issues * changelog: Improvements, Accessibility, Change hint text from span to div
* Fix flaky spec for awaited fetch request changelog: Internal, Analytics, Add logging for password visibility toggle clicked * Add clarifying comment * Remove unused helper module
…te. (#7038) * remove additional phone step * changelog:Upcoming Features,InheritedProofing,Fixflowstatesteps * Remove unused file and indicator step
* Better vertical centering for account deleted icon changelog: Internal, Accessibility, adjusting icon position * Switching to modifier classname for the styling changelog: Internal, Styling, updating icon centering
* Standardize phone_number name changelog: Internal, Attempts API, Standardize events
* changelog: Improvements, OIDC Logout, Support Confirming OIDC Logout when logging out without id_token_hint Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: Bug Fixes, Templates, Fix height and alt attribute on images
changelog: Bug Fixes, In-person proofing, Improve job error handling
jmdembe
approved these changes
Sep 29, 2022
mitchellhenke
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal
Upcoming Features