Better Account Deleted Icon Centering

[eric-gade]

changelog: Internal, Accessibility, adjusting icon position

🛠 Summary of changes

Updated the alert-icon component sass to include a new convenience class.

Updated the account confirm deleted view to use the new class, which better centers the icon vertically

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Clone locally and setup
• change the value of email in app/controllers/account_reset/confirm_delete_account_controller.rb to be any string
• make run
• Create an account. Then manually navigate to http://localhost:3000/account_reset/confirm_delete_account to see the result

👀 Screenshots

Before:

After:

🚀 Notes for Deployment

Include any special instructions for deployment.

[benjaminchait]

This all looks like CSS changes, I haven't run locally but everything seems reasonable.

[aduth]

👍

[aduth]

This looks like it could be a modifier in our convention of using BEM methodology (docs could be clearer, admittedly):

Suggested change

	.alert-icon-centered-top {
	.alert-icon--centered-top {

[eric-gade]

Also I just noticed the login design system link is broken in the Frontend README (it shows https://design.login.gov/components/)

[aduth]

Also I just noticed the login design system link is broken in the Frontend README (it shows https://design.login.gov/components/)

Good catch! (Though personally that sounds more like an issue with the Design System docs not having a good redirect for that path, since I think it should be a valid URL)

Edit: For posterity, fix for documentation is at 18F/identity-design-system#323 .