Refactor account personal key reset to use verify flow steps

[aduth]

Why: So that we're not permanently maintaining two separate implementations, aim to reuse the new FormSteps-based implementation. Future work should remove the "shared/personal_key" partial and "personal-key-page-controller" script once the IdV app has shipped and stabilized.

Open questions:

• Do we need a no-JS fallback for this since it technically falls outside of identity verification?
  • Option 1: Use our new JavascriptRequiredComponent to enforce JS is enabled
  • Option 2: Add a basic no-JS fallback implementation which just shows the static content (Edit: Implemented in 06c31d1)
• There may be feature specs associated with this screen which now need to enable JavaScript

[aduth]

Do we need a no-JS fallback for this since it technically falls outside of identity verification?

In 06c31d1, I opted to restore the static markup for the page to support no-JS environments. In the future, assuming we want to continue supporting no-JS for this page, we could at least remove all of the related JavaScript supports (personal-key-page-controller.js, relevant partial markup supports for JavaScript).

[zachmargolis]

oh yikes I'm surpised we used alias instead of alias_method ... glad to see this go

[zachmargolis]

silly question, how do the values get in to this form before we submit it? it looks like the form lives outside of appRoot?

[aduth]

Not a silly question. The server-side controller doesn't actually care about any submitted values 🙃 The personal key is generated when the page is shown, and the form submission is basically just a redirect.

Page show:

identity-idp/app/controllers/accounts/personal_keys_controller.rb

Lines 13 to 22 in 8cb2802

	def create
	user_session[:personal_key] = create_new_code
	analytics.profile_personal_key_create
	create_user_event(:new_personal_key)
	result = send_new_personal_key_notifications
	analytics.profile_personal_key_create_notifications(**result.to_h)
	flash[:info] = t('account.personal_key.old_key_will_not_work')
	redirect_to manage_personal_key_url
	end

Page submit:

identity-idp/app/controllers/users/personal_keys_controller.rb

Lines 22 to 25 in 8cb2802

	def update
	user_session.delete(:personal_key)
	redirect_to next_step
	end

[zachmargolis]

🤦 thanks, I forgot that checking the personal key was all JS before anyways

[zachmargolis]

LGTM