changelog: Improvements, Authentication, Update from cancel to skip for now#7025
Merged
changelog: Improvements, Authentication, Update from cancel to skip for now#7025
Conversation
aduth
approved these changes
Sep 26, 2022
|
|
||
| <%= render 'shared/cancel', link: @after_setup_path %> | ||
| <%= render PageFooterComponent.new do %> | ||
| <%= link_to t('mfa.skip'), @after_setup_path, method: :get, class: 'usa-button usa-button--unstyled' %> |
Contributor
There was a problem hiding this comment.
The method and class values here don't seem necessary, since a link would be GET by default, and usa-button--unstyled is designed for styling a button to appear as a link, but this is a link already.
Suggested change
| <%= link_to t('mfa.skip'), @after_setup_path, method: :get, class: 'usa-button usa-button--unstyled' %> | |
| <%= link_to t('mfa.skip'), @after_setup_path %> |
mitchellhenke
approved these changes
Sep 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-6918: Authentication update CTA
🛠 Summary of changes
This will change the language of the link at the secondary MFA page to "Skip for now"
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
What it will look like after change.
