Make sign-in page buttons big to improve button style consistency#7032
Merged
mitchellhenke merged 3 commits intomainfrom Sep 27, 2022
Merged
Make sign-in page buttons big to improve button style consistency#7032mitchellhenke merged 3 commits intomainfrom
mitchellhenke merged 3 commits intomainfrom
Conversation
changelog: Improvements, Style, Make sign-in page buttons big to improve consistency
aduth
approved these changes
Sep 27, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM from a technical point-of-view 👍
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
anniehirshman-gsa
approved these changes
Sep 27, 2022
Contributor
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
LGTM3, thank you!!
(Just checking: this also applies to the version of the Sign in page where the SP is connected?)
Contributor
Author
Yep! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
While working with @anniehirshman-gsa on #7017, she suggested that the sign-in page buttons could be updated to match other buttons. This PR is a small style change to make sign-in page buttons use the "big" style to match buttons elsewhere on the site.
👀 Screenshots