Merged
Conversation
changelog: Internal, Analytics, Add logging for password visibility toggle clicked
eric-gade
approved these changes
Sep 28, 2022
Contributor
eric-gade
left a comment
eric-gade
left a comment
There was a problem hiding this comment.
Looks good, and works on my end
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Resolves intermittent test failures caused by a race condition between user interaction in the feature spec and the JavaScript
fetchrequest being settled.Related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1664317848054629
There should be a way to have the test helper work as expected, but this appears to work as a simpler alternative. The issue with the test helper appears to be that the
Timeout.timeoutloop only loops once and does not actually wait forwindow.isFetchingto becomefalse.📜 Testing Plan
rspec spec/features/users/sign_in_spec.rb:220