Merged
Conversation
This reverts commit 965177f.
* FullScreen: Support background color customization * initial upgrade to acuant v11.5.0 * move fullscreen into acuantcapturecanvas * Revert "move fullscreen into acuantcapturecanvas" This reverts commit ffd83e51d3abe450fd997cae91fa20bdf4e86703. * implement usecookie hook **why**: to read from and set the cookie assigned by acuant v11.5.0 for graceful manual fallback capture * handle acuant sequence break failure as failed to start bypass acuant manual fallback, since (a) it introduces delays we're not yet accommodating for in UX and (b) it doesn't fit our current model of capture sources as "acuant" or "manual", where the acuant graceful fallback is somewhere in between the two (applies cropping and metrics, but not captured with guided frames) * remove element remove override **why**: was originally intended to prevent acuant from stopping manual capture when "end"-ing in response to failed capture / fullscreen dialog close. since we now bypass acuant's manual capture, it's not needed * Move up acuant access failure check **why**: simplify diff * skip worker start if camera not supported * Remove unused accessible status labels * move inline styles to stylesheet **why**: avoid csp errors * add specs for fullscreen bgcolor prop * Revert "skip worker start if camera not supported" This reverts commit 60676bc188a4631ab91bd4b503500f07a2868f6a. * Add inline documentation for useCookie * Add useCookie specs * Clean-up acuantcameracreated callback in useEffect * Update Acuant canvas button to explicitly click canvas **Why**: Previously relied on event bubbling when within the canvas fallback content. * Restore cropping failure handling * Fix JavaScript specs * Fix type error for useCookie setter * Resolve lint error on CSS property order * Rearrange shouldStartAcuantCaptpure logic to appease codeclimate * Restore script_src unsafe-eval for document capture CSP **Why**: Still needed in Android Chrome * Avoid parsing full cookie string, find value by name See: #5590 (comment) * Remove bgColor feature for FullScreen **Why**: Decided against it for now * Center acuant canvas in landscape orientation * Disable CodeClimate complex-logic * Customize iOS 15 sequence break error message **Why**: Per UX feedback
- Pre-work for dropping the columns from the DB
* Increase TOTP secret length from 80 bits to 160 bits **Why**: [RFC 4226](https://datatracker.ietf.org/doc/html/rfc4226) specifies that the length should meet or exceed 128 bits.
* Flip order of Geocoder conditional, positive test case first * Force Geocoder to load the database by doing a lookup (LG-5318)
**How**: By making sure all queries are wrapped in a transaction timeout block
* add failing spec * show last sign in email address in authorization confirmation
* Move telephony gem files to lib. * Move telephony gem specs to spec. * Remove telephony gem references from Gemfile. * Add pinpoint dependencies to Gemfile. * Migrate and normalize telephony i18n yaml files. * Move telephony spec_helper to shared_context. * Configure i18n-tasks to look inside lib/ dir as well (#5599) * Try resetting Telephony.config after tests to reduce test pollution (#5600) * Change `strip.gsub` to `squish`. * Add test for invalid phone number.
**How**: Without the transaction_with_timeout block, it runs against the primary DB, but the same query against the read replica is fine
* LG-4826: Remove reference to hello@login.gov * LG-4826: add link error * Rubocop * Linting and fix tests * update english translation * update language * error
**Why**: To help ensure that people see it and don't enter PII
LG-4876 Adding the new doc capture error warning view after failure but before review step. Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
**Why**: So that SAML SPs can request all of a user's email addresses
* Remove unused methods from lib/telelphony. * Remove tests for deleted method. * Remove previously commented methods. * Remove additional test. * Remove unused translations.
aduth
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.