Configure i18n-tasks to look inside lib/ dir as well#5599
Merged
zachmargolis merged 1 commit intodayton-incorporate-telephony-gemfrom Nov 9, 2021
Merged
Conversation
kevindayton
added a commit
that referenced
this pull request
Nov 12, 2021
* Move telephony gem files to lib. * Move telephony gem specs to spec. * Remove telephony gem references from Gemfile. * Add pinpoint dependencies to Gemfile. * Migrate and normalize telephony i18n yaml files. * Move telephony spec_helper to shared_context. * Configure i18n-tasks to look inside lib/ dir as well (#5599) * Try resetting Telephony.config after tests to reduce test pollution (#5600) * Change `strip.gsub` to `squish`. * Add test for invalid phone number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured out why the i18n-tasks gem thought a bunch of keys were unused