Merged
Conversation
**Why**: To help ensure that people see it and don't enter PII
zachmargolis
approved these changes
Nov 16, 2021
| @@ -1,3 +1,3 @@ | |||
| <div class='padding-y-1 bg-secondary-darker text-white fs-12p line-height-1 center'> | |||
| <div class='h1 padding-y-4 bg-secondary-darker text-white fs-12p line-height-1 center'> | |||
Contributor
There was a problem hiding this comment.
I vote for even bigger!! cover half the screen!
another idea I'd like us to consider is adding something inline next to the SSN field and other PII fields because of banner blindness
Contributor
Author
There was a problem hiding this comment.
Yeah, planning on cooking something like that up. This is the late in the evening quick win version.
aduth
reviewed
Nov 16, 2021
| @@ -1,3 +1,3 @@ | |||
| <div class='padding-y-1 bg-secondary-darker text-white fs-12p line-height-1 center'> | |||
| <div class='h1 padding-y-4 bg-secondary-darker text-white fs-12p line-height-1 center'> | |||
Contributor
There was a problem hiding this comment.
h1 is a BassCSS class. A design system class like font-sans-lg would have been preferable toward moving off BassCSS.
Suggested change
| <div class='h1 padding-y-4 bg-secondary-darker text-white fs-12p line-height-1 center'> | |
| <div class='font-sans-lg padding-y-4 bg-secondary-darker text-white fs-12p line-height-1 center'> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To help ensure that people see it and don't enter PII
Screenshot:
