Merged
Conversation
aduth
commented
Nov 8, 2021
app/javascript/packages/document-capture/components/acuant-capture.jsx
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
Nov 8, 2021
aduth
commented
Nov 9, 2021
d1d043a to
16f68c6
Compare
Contributor
Author
|
CodeClimate is taking issue with "complex logic" hereabouts: It didn't seem to take the refactoring in a677e2b as an improvement. I'm not really convinced it's worth worrying about much? |
958181f to
2a2ac64
Compare
zachmargolis
reviewed
Nov 9, 2021
app/javascript/packages/document-capture/components/acuant-capture.jsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
A few small updates from bug bash testing:
|
This reverts commit ffd83e51d3abe450fd997cae91fa20bdf4e86703.
**why**: to read from and set the cookie assigned by acuant v11.5.0 for graceful manual fallback capture
bypass acuant manual fallback, since (a) it introduces delays we're not yet accommodating for in UX and (b) it doesn't fit our current model of capture sources as "acuant" or "manual", where the acuant graceful fallback is somewhere in between the two (applies cropping and metrics, but not captured with guided frames)
**why**: was originally intended to prevent acuant from stopping manual capture when "end"-ing in response to failed capture / fullscreen dialog close. since we now bypass acuant's manual capture, it's not needed
**why**: simplify diff
**why**: avoid csp errors
This reverts commit 60676bc188a4631ab91bd4b503500f07a2868f6a.
**Why**: Previously relied on event bubbling when within the canvas fallback content.
to appease codeclimate
**Why**: Still needed in Android Chrome
**Why**: Decided against it for now
**Why**: Per UX feedback
7cf8b6b to
f5db1c0
Compare
Contributor
Author
|
@anniehirshman-gsa Based on our discussion, I customized the error message specific to the iOS 15 crash (f5db1c0): (In this example, I was re-taking a photo, hence why the field already has a preview) |
Merged
Contributor
LGTM, thanks for confirming with the screenshot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a user, I expect that login.gov keeps their vendor dependencies up-to-date, so that bug fixes that may improve my likelihood of proofing success have been incorporated.
The v11.5.0 release is a major release which improves detection and handling for an ongoing iOS 15 "GPU Highwater" issue, and which should resolve issues with iPhone Pro Max devices.
Full changelog: https://github.com/Acuant/JavascriptWebSDKV11/releases
Migration guide: https://github.com/Acuant/JavascriptWebSDKV11/blob/master/SimpleHTMLApp/docs/MigrationDetails.md
Note that we are upgrading from v11.4.3 to 11.5.0, so this also includes changes from v11.4.4, v11.4.5, v11.4.6, and v11.4.7.
Implementation Notes:
AcuantCamera.jsaria-liveregion, so we are able to remove our handling of this behavior. We still include accessible heading, instructions, and button click-to-capture, since these are not included in Acuant's implementation.