Increase TOTP secret length from 80 bits to 160 bits#5604
Merged
Conversation
**Why**: [RFC 4226](https://datatracker.ietf.org/doc/html/rfc4226) specifies that the length should meet or exceed 128 bits.
mitchellhenke
approved these changes
Nov 12, 2021
| @@ -287,7 +287,7 @@ | |||
| it 'generates a secret 16 characters long' do | |||
Contributor
There was a problem hiding this comment.
this spec title is now wrong
Suggested change
| it 'generates a secret 16 characters long' do | |
| it 'generates a secret 32 characters long' do |
|
|
||
| def generate_totp_secret | ||
| ROTP::Base32.random_base32(16) | ||
| ROTP::Base32.random(20) |
Contributor
There was a problem hiding this comment.
what if we left a comment here describing the # of bits?#5604
Suggested change
| ROTP::Base32.random(20) | |
| ROTP::Base32.random(20) # 160-bit secret, per RFC 4226 |
Contributor
|
I think this might have caused some visual oddity on the auth app setup screen?
|
Contributor
For posterity: Ticket filed at LG-5436 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: RFC 4226 specifies that the length should meet or exceed 128 bits.