Preload geocoder database, to minimize timeouts#5603
Merged
zachmargolis merged 2 commits intomainfrom Nov 12, 2021
Merged
Conversation
zachmargolis
commented
Nov 10, 2021
| file: GEO_DATA_FILEPATH, | ||
| }, | ||
| ) | ||
| Geocoder.search('1.2.3.4') # the datasource is lazily loaded, make sure it eager loads |
Contributor
Author
There was a problem hiding this comment.
this line is the meaningful change in here (6d2a310)
jmhooper
approved these changes
Nov 12, 2021
mitchellhenke
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We see a few occasional geocoder timeouts in prod while reading from disk, my hypothesis was that the Geocoder gem lazily loads its datasource.
In a fresh Rails console in INT, I believe I confirmed this. The first lookup is ~0.1 seconds, and subsequent lookups are at least 200x faster, no matter the order or values, so I am pretty sure the first one forces a lookup
The first commit (c4e57b5) was just a personal preference of trying to have "positive" conditions first, which I think reads better.
The "meat" of this PR is 6d2a310