Incorporate telephony gem into IDP (LG-4987)#5586
Merged
kevindayton merged 24 commits intomainfrom Nov 12, 2021
Merged
Conversation
zachmargolis
reviewed
Nov 5, 2021
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
Awesome start! A few comments
zachmargolis
reviewed
Nov 8, 2021
zachmargolis
reviewed
Nov 8, 2021
...context.
- This will be resolved in a upcoming ticket that switches it to the constant.
kevindayton
force-pushed
the
dayton-incorporate-telephony-gem
branch
from
5683baf to
f4c9fb7
Compare
zachmargolis
approved these changes
Nov 10, 2021
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM a few last nits, nothing major
kevindayton
force-pushed
the
dayton-incorporate-telephony-gem
branch
from
c8da6d6 to
bb2257c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.