Deploy RC 135 to Production#4831
Merged
zachmargolis merged 25 commits intostages/prodfrom Mar 25, 2021
Merged
Conversation
* make the addition of attempts_remaining more explicit (LG-4252) * Better handling of extra attributes. Fixes errors.
**Why**: As a user, I expect that login.gov keeps their vendor dependencies up-to-date, so that bug fixes that may improve my likelihood of proofing success have been incorporated. Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
…ve (#4812) * Change Acuant initialization endpoint CSP host * Restore old authorization endpoint
**Why**: This lets us configure the worker and web hosts with separate secrets and configs if needed
**Why**: As follow-up to #4812, remove old Acuant SDK initialization endpoint. As of Acuant Web SDK v11.4.2, the endpoint has changed to the acuant.net host already present in the CSP headers. See: - https://github.com/Acuant/JavascriptWebSDKV11/blob/master/SimpleHTMLApp/docs/MigrationDetail11.4.2.md - #4812
* LG-4305: Log new event in case of lockout from proofing **Why**: As a login.gov developer, i want to see an event in the event log that indicates that a user was locked out for 6 hours from proofing along with the relevant data points that directly resulted in that lockout, so that I can troubleshoot any issues reported by end users and pinpoint exactly what caused the lock out. * Consolidate rate limit triggered to single event **Why**: Easier queryability of events, fewer and more consistent events, compatibility with potential future refactor to move event logging into throttle service or model. * Handle throttler trigger logging behavior in Throttler service **Why**: Encapsulate behaviors of throttling within existing service behaviors * Include analytics in verify_document_action
…system (#4815) * Refactor button "isPrimary" as "isWide" **Why**: As part of LG-3865, what's currently referenced as "primary" is the default appearance of a button, and is not tied to the wide appearance of a button. * Rename secondary button as outline button **Why**: As part of LG-3865, "secondary" button type is called "outline". This is purely a naming change, where the visual appearance of "outline" and "secondary" are expected to be identical.
**Why**: To correctly pass in timeout configs
* Add a rake task for reporting deployments to NewRelic **Why**: Our NewRelic config expects several tools to be part of the runtime in order to work. This means that `bundle exec newrelic deployment` breaks because it does not load the rails environment and thusly does not load AppConfig or Identity::Hostdata. This change is the third of these solutions I investigated: 1. Add an ERB block to the NR config to setup AppConfig and load Hostdata 2. Completely rebuild the NR config to use env vars instead of our app's tooling (eventually we should pursue this as it is a better long-term solution) 3. Wrapping the deployment call in a rake task that loads the rails environment
* initial job implementation * encrypt and put pii in arguments * install delayed_job * updates * use keyword arguments in jobs * fix indenting * rename argument * rubocop * consistent key access style * enable ruby workers in test * Update app/jobs/document_proofing_job.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/jobs/address_proofing_job.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * symbolize all decrypted args * fix specs * remove outdated spec * add job specs * make email delivery always synchronous Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…ML (#4807) * Allow default attributes for IAL2 SAML * default to ial2 only if requested ial is nil * add spec * move tests to ial context * Added tests for ial2_or_greater
* Throttle personal key verification attempts * add translations
…ml is nil (#4828) **Why**: If the `web_or_worker_yml` method returns `nil`, then we'll try to load configs from `$IDP_BASE/config/`. This doesn't work because a directory is not valid yaml.
* remove deprecated piv/cac error routes * remove unused i18n keys
**Why**: Version 0.3.5 was yanked, this one is not yanked... yet
* Upgrade to identity-style-guide 5.0.3 **Why**: Fix unstyled button link appearance * LG-3865: Update BassCSS link buttons to USWDS **Why**: We should be able to expect that the visual appearance of BassCSS `btn-link` and the USWDS unstyled button are identical. As such, migrating to the unstyled button can happen independently of the broader BassCSS migration to simplify future effort. Excludes SimpleForm buttons, since all SimpleForm buttons will apply the `btn btn-primary` class which may conflict with USWDS buttons. This is also why the class isn't yet deprecated in the erb-lint.yml file. See: https://github.com/18F/identity-idp/blob/ce7608a50ea9f7b8d8c747c63cc0c49549eac4a7/config/initializers/simple_form.rb#L5 * Revert hover color to default link color See inline comment * Update selector for back link test * Preserve link color for visited, unstyled buttons **Why**: See inline code comment * Apply inherited font smoothing to hover, active unstyled buttons **Why**: 18F/identity-design-system#202 and 18F/identity-design-system#201 intended to inherit font smoothing, but unfortunately miss these two states which are handled and inherited from USWDS.
zachmargolis
requested review from
aduth,
jmhooper,
mitchellhenke,
solipet and
stevegsa
Contributor
|
you are going to have to work a lot harder if you want the capitals (LGTM) |
zachmargolis
force-pushed
the
stages/rc-2021-03-25
branch
from
8539e76 to
f09984b
Compare
Contributor
Author
This reverts commit 24dcf62.
Contributor
Author
zachmargolis
force-pushed
the
stages/rc-2021-03-25
branch
from
f8ccdc6 to
18fb52d
Compare
mitchellhenke
approved these changes
Mar 25, 2021
aduth
approved these changes
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a patch release (#4813) in there that made for some merge conflicts, so I ran:
to true-up with the
mainbranch