Add a rake task for reporting deployments to NewRelic#4823
Merged
Conversation
**Why**: Our NewRelic config expects several tools to be part of the runtime in order to work. This means that `bundle exec newrelic deployment` breaks because it does not load the rails environment and thusly does not load AppConfig or Identity::Hostdata. This change is the third of these solutions I investigated: 1. Add an ERB block to the NR config to setup AppConfig and load Hostdata 2. Completely rebuild the NR config to use env vars instead of our app's tooling (eventually we should pursue this as it is a better long-term solution) 3. Wrapping the deployment call in a rake task that loads the rails environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Our NewRelic config expects several tools to be part of the runtime in order to work. This means that
bundle exec newrelic deploymentbreaks because it does not load the rails environment and thusly does not loadAppConfigorIdentity::Hostdata.This change is the third of these solutions I investigated: