Don't try to apply web or worker config overrides if web_or_worker_yaml is nil#4828
Merged
Don't try to apply web or worker config overrides if web_or_worker_yaml is nil#4828
Conversation
…ml is nil **Why**: If the `web_or_worker_yml` method returns `nil`, then we'll try to load configs from `$IDP_BASE/config/`. This doesn't work because a directory is not valid yaml.
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, whoops, thanks for catching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: If the
web_or_worker_ymlmethod returnsnil, then we'll try to load configs from$IDP_BASE/config/. This doesn't work because a directory is not valid yaml.