LG-3865: Update React button component prop names to align to design system#4815
Merged
LG-3865: Update React button component prop names to align to design system#4815
Conversation
**Why**: As part of LG-3865, what's currently referenced as "primary" is the default appearance of a button, and is not tied to the wide appearance of a button.
**Why**: As part of LG-3865, "secondary" button type is called "outline". This is purely a naming change, where the visual appearance of "outline" and "secondary" are expected to be identical.
mitchellhenke
approved these changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks only to update the React
<Button />component's prop names semantics to align to current design system guidance. It's not intended to include any visual changes. The implementation still uses BassCSS, but this will reduce the impact of future revisions to migrate to design system CSS classes.Reference: https://design.login.gov/components/buttons/
Why: As part of LG-3865, what's currently referenced as "primary" is the default appearance of a button, and is not tied to the wide appearance of a button.
Why: As part of LG-3865, "secondary" button type is called "outline". This is purely a naming change, where the visual appearance of "outline" and "secondary" are expected to be identical.