Revert "LG-4305: Log new event in case of lockout from proofing"#4824
Merged
Revert "LG-4305: Log new event in case of lockout from proofing"#4824
Conversation
aduth
force-pushed
the
revert-4803-aduth-lg-4305-log-throttle
branch
from
e3b4790 to
2dafff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4803
Relevant Slack discussion: https://gsa-tts.slack.com/archives/CNCGEHG1G/p1616516384008900
The logging approach implemented in #4803 is problematic in that it logs an event when the user exhausts all available attempts within a throttle, even if they are successful in their final attempt. Since we're more interested in situations when a user would encounter a throttle error, we'll want to revisit how we implement this.
Opening this as a stub to ensure the changes from #4803 would not go live in this release. I'll plan to iterate separately on an improved solution, which may end up looking a bit more like the original commits from #4803 (1ce2437 + 4d197cc).