LG-3840 Updated welcome and new agreement pages

[stevegsa]

Welcome screen

Agreement screen

[aduth]

Looks like the fourth bullet item is breaking onto a new line:

[zachmargolis]

Looks like the fourth bullet item is breaking onto a new line:

Thanks for checking, @aduth ! @stevegsa, next time there are visual changes in a PR can you help us include a screenshot for context?

[stevegsa]

Sure thing but I never marked it ready for review :-)

[aduth]

My mistake, I was going by

I'll check for the label next time

[stevegsa]

No worries I took it out of draft optimistically this morning thinking the label was forthcoming...my bad

[stevegsa]

cc @anniehirshman-gsa @Danielle-Lee

[stevegsa]

I'm going to convert that dash to an em dash

[stevegsa]

Spacing needs some tweaks too

[anniehirshman-gsa]

Thanks, screenshots are looking pretty good! @stevegsa I have some questions about the headings and list items styles, but it's hard to tell without previewing it, so I've set up a couple minutes for later today to walk through it (feel free to move around if there's another time you prefer)

[zachmargolis]

LGTM, some small suggestions, also want to make sure we get @anniehirshman-gsa 's signoff

[aduth]

Should fix up the Spanish heading, but otherwise LGTM 👍

[anniehirshman-gsa]

To recap yesterday's sync:

1. Adjusted visual style of h1s (kept consistent with current h1s on other pages) and list items (same size on mobile and desktop).
2. Adjusted spacing of list items so they align with the blue numbers.

And now LGTM! I will investigate h1 heading size and required field behavior separately from this ticket (outside of scope).

[amathews-fs]

@stevegsa Just to make sure I'm getting this correctly:

This is a new step in the FSM between Welcome and Upload all the normal FSM logged events should appear as expected and will not effect the log events for either Welcome or Upload?

[zachmargolis]

@stevegsa Just to make sure I'm getting this correctly:

This is a new step in the FSM between Welcome and Upload all the normal FSM logged events should appear as expected and will not effect the log events for either Welcome or Upload?

Random thought, we do we have any specs that ensure all the events we reference in the funnel dashboard get logged (ex so we can catch regressions that would affect the funnel dashboard before they merge?)

[amathews-fs]

Random thought, we do we have any specs that ensure all the events we reference in the funnel dashboard get logged (ex so we can catch regressions that would affect the funnel dashboard before they merge?)

@zachmargolis I don't think we have anything really centralized or assured coverage for that no. There are tests that do expect some events but it hasn't been something consistently done in the past. It's a good idea. I brought it up today in sprint review to look at spending some time making a IAL2 logging test suite to assure we at least don't have regressions.

[stevegsa]

@stevegsa Just to make sure I'm getting this correctly:

This is a new step in the FSM between Welcome and Upload all the normal FSM logged events should appear as expected and will not effect the log events for either Welcome or Upload?

That is correct.