Throttle personal key verification attempts (LG-4354)#4820
Merged
mitchellhenke merged 2 commits intomainfrom Mar 23, 2021
Merged
Throttle personal key verification attempts (LG-4354)#4820mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/throttle-personal-key-verification
branch
from
1171c48 to
7756588
Compare
jmhooper
reviewed
Mar 23, 2021
Contributor
There was a problem hiding this comment.
Does it make sense to write something to the analytics hash when we're throttled?
Contributor
Author
There was a problem hiding this comment.
Yeah, something should be logged. #4803 created new events. Does it make sense to keep that pattern here too (and for an upcoming PR on rate limiting GPO attempts)?
Contributor
Author
There was a problem hiding this comment.
Andrew's work in #4803 made it much easier, only had to pass in analytics to the throttle call and it took care of the rest. Also updated the specs.
mitchellhenke
force-pushed
the
mitchellhenke/throttle-personal-key-verification
branch
from
7756588 to
73ef5b8
Compare
stevegsa
approved these changes
Mar 23, 2021
Contributor
stevegsa
left a comment
stevegsa
left a comment
There was a problem hiding this comment.
LGTM. (other than the i18n build error...)
mitchellhenke
force-pushed
the
mitchellhenke/throttle-personal-key-verification
branch
2 times, most recently
from
96f2757 to
1507f08
Compare
mitchellhenke
force-pushed
the
mitchellhenke/throttle-personal-key-verification
branch
from
1507f08 to
3c60ec2
Compare
mitchellhenke
deleted the
mitchellhenke/throttle-personal-key-verification
branch
aduth
added a commit
that referenced
this pull request
Mar 24, 2021
aduth
added a commit
that referenced
this pull request
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This throttles the number of times a user can try to re-verify their account with their personal key. Upon throttling, they'll see:
Messaging was copied from existing cases of throttling. (Draft while awaiting translations)