Staging: Deploy acuant cost code#4006
Merged
zachmargolis merged 15 commits intostages/stagingfrom Aug 4, 2020
Merged
Conversation
Add dashboard logout URI to redirect_uris
* Look up user by Agency UUID, not just Identity UUID **Why**: The id_token.sub we expose to apps is shared across agencies
…3986) * Replace static page contents with mounted React application **Why**: Static content is intended as a fallback in case e.g. JavaScript is disabled * Set AcuantCapture component as second form step **Why**: To create a more sensible flow where the second step involves selfie capture * Add closing div to server-rendered selfie target * Render static "Start Over" and "Cancel" outside React container **Why**: These should always be visible, and don't need to be controlled by React * Enable document capture environment variable for steps **Why**: The purpose of the spec is to verify document capture flow, which is rendered only under the condition that the environment variable is assigned as `'true'`
* Update WebAuthn tests to use DOM global assigned by JSDOM * Add Chai plugin to verify expected console logging * Extract DOM test helpers to DOM support file * Handle script load error in Acuant context provider **Why**: The current error state handling for Acuant initialization only handles the case that the Acuant script successfully loads, and then an error occurs during initialization. These changes ensure that it is similarly treated as an error in case that the Acuant script fails to load for any reason. * Remove unused atob, btoa dependencies * Disable ESLint rule function-paren-newline **Why**: Airbnb rules conflict with Prettier styling. Rely on Prettier styling to take priority * Delete unverifiedCalls if empty **Why**: afterEach verifies as explicitly undefined, not empty. If a verified call would make the array empty, it must be deleted * Support testing console error by regular expression **Why**: Give us more confidence the error that was logged is the one we're expecting * Rename logged to loggedError **Why**: There's many subtypes of console logging. At the moment we're only concerned with error logging, but this may expand in the future. It's helpful to disambiguate now to support that use case * Remove superfluous double-quote **Why**: Not intended for the message
**Why**: To take advantage of accessibility improvements offered by leveraging the upstream USWDS. **Why**: To remove duplicate code, and to avoid the overhead involved in maintaining duplicate code. **Why**: To use Login Design System standardized HTML markup. **Why**: In the effort to migrate Slim views to ERB.
**Why**: To fix an issue where if there's another occurrence of a quote within the same line as a matched asset path, the path would wrongly include the text up to the last occurrence of a quote in the line
* Add DeviceContext context
**Why**: Since the design incorporates elements which vary depending on support for rear-facing ("environment") and front-facing ("user") video capture support, we need a means to be able to make this value available to all components of the application
* Add documents introduction component
**Why**: While the introductory text is the same for desktop and mobile, on mobile devices it (1) occurs as its own standalone step and (2) includes one fewer instructions items (file size recommendation)
* Abstract PageHeading component
**Why**: To consolidate styling for page headings, in anticipation of future refactoring away from using Basscss
* Render introductory instructions common to all devices
* Align locale string naming to #3994
**Why**: To simplify future reconciliation
* Simplify DeviceContext to simple object of isMobile
**Why**: While we may need more granular detail of device-specific constraints, it's unclear as of yet how that will be implemented.
* LG-3191: mobile document capture step * LG-3191: rearrange desktop page to new design * LG-3191: clean up specs. Allow react components to be disabled for dev/test * locales - translations and normalization
* Add formatHTML to useI18n to format HTML in string **Why**: Localized strings may contain HTML markup, which React will escape by default. This provides a mechanism to be able to safely replace intended HTML markup with equivalent React elements substitutes. * Update file input to use underlined choose text * Further clarify limitations of formatHTML **Why**: The implementation is acknowledged as naive. Use documentation to prevent developer from getting themself in trouble * Update string underline to use custom tag name **Why**: Clarifies that it relies on React interpolation to replace with styles
* Add accessibility tests to IAL2 steps * Add accessbility specs to device events, cancel registration page and delete user pages * Include alt text * Label image upload file input * Replace h2 with required h1 * Convert footer to erb * Add aria-label to link without text * Convert event_item to erb * Convert verified account badge to erb * Add alt text to verified account badge * Convert events show to erb * Put header on device events page * Fix webauthn input label * Update app/views/shared/_footer_lite.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/views/idv/doc_auth/front_image.html.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Fix merge * Rubocop Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Use animated ID card for doc auth loading interstitial **Why**: The Clock icon was used as a temporary asset, and is not intended for use in the final design for this screen. An animation effect was added to the card to give the user the impression there is activity happening in the background, so that they aren't confused into thinking the process has stalled. * Add mechanism to bypass SVG style test spec **Why**: If there can be a justified reason that the style tag validation should be bypassed, a developer should be able to opt out via explicit override. * Rename test override pattern to lint-ignore **Why**: More accurate as describing static analysis of our code quality checks Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> * Use percent literal syntax for regular expression pattern **Why**: To avoid escaping forward slashes Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Zach Margolis <zbmargolis@gmail.com>
…es. (#3998) LG-3177 Update associated gems to the new typhoeus-less versions. Fix problems with google analytics class after switch to net_http. Typhoeus has been removed from all dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to deploy #4001 so that I can test it in staging, in a real environment where we actually talk to the vendor (instead of mocking)