Update accordion to use Login Design System#3974
Merged
Conversation
**Why**: To take advantage of accessibility improvements offered by leveraging the upstream USWDS. **Why**: To remove duplicate code, and to avoid the overhead involved in maintaining duplicate code. **Why**: To use Login Design System standardized HTML markup. **Why**: In the effort to migrate Slim views to ERB.
aduth
force-pushed
the
aduth-lg-accordion
branch
from
b957121 to
afc0d5c
Compare
Contributor
Author
|
Noting that this will indirectly resolve LG-3194 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #3957
Removes custom accordion implementation, instead taking advantage of existing Login Design System component availability.
Why: To take advantage of accessibility improvements offered by leveraging the upstream USWDS.
Why: To remove duplicate code, and to avoid the overhead involved in maintaining duplicate code.
Why: To use Login Design System standardized HTML markup.
Why: In the effort to migrate Slim views to ERB.
Screenshot: