Add document capture introduction component#3990
Merged
Conversation
75c3b45 to
2539e5a
Compare
**Why**: Since the design incorporates elements which vary depending on support for rear-facing ("environment") and front-facing ("user") video capture support, we need a means to be able to make this value available to all components of the application
**Why**: While the introductory text is the same for desktop and mobile, on mobile devices it (1) occurs as its own standalone step and (2) includes one fewer instructions items (file size recommendation)
**Why**: To consolidate styling for page headings, in anticipation of future refactoring away from using Basscss
**Why**: To simplify future reconciliation
2539e5a to
03b45f5
Compare
**Why**: While we may need more granular detail of device-specific constraints, it's unclear as of yet how that will be implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: LG-3251
Add DeviceContext context
Why: Since the design incorporates elements which vary depending on support for rear-facing ("environment") and front-facing ("user") video capture support, we need a means to be able to make this value available to all components of the application
Add documents introduction component
Why: While the introductory text is the same for desktop and mobile, on mobile devices it (1) occurs as its own standalone step and (2) includes one fewer instructions items (file size recommendation).
Screen Recording:
Note that the text "File size should be at least 2 MB" appears only if the user agent is not that of a mobile device.
Notes:
PageHeadingcomponent was created with the sole purpose to abstract the implementation detail of consistency with current heading styling (using Basscss) in a way that can seamlessly be migrated to use Login Design System in the future.In Progress, To Do:Automated test cases for different device support flows(73ad86bb3)Localize introductory text(a18bc2dea)Styling(9b2a151)Inline documentation for(4e51a9020)useDeviceHasVideoFacingModehookAutomated testing for(b8edf3fb9)useDeviceHasVideoFacingModehookShare screenshot or screen recording