LG-3221: Accessibility for IAL2 flow#4000
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/lg-3221-accessibility-axe-idv
branch
from
69bb096 to
00e02e1
Compare
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
Some of the accessibility fixes included converting the slim template to erb which makes the diff hard to see on github, so I've commented on those.
app/views/events/show.html.erb
Outdated
There was a problem hiding this comment.
This was previously in the blue box, but the page lacked the required h1 element, so I moved it up to become the header.
Previous:
Now:
Commit diff of accessibility change: ea4b952
There was a problem hiding this comment.
The text associated with this link doesn't appear on mobile due to sm-show, so I added an aria-label and now screen reader announces link as "US General Services Administration" instead of reading out the URL.
Commit diff of accessibility change: ff4e7e5
… delete user pages
mitchellhenke
force-pushed
the
mitchellhenke/lg-3221-accessibility-axe-idv
branch
from
00e02e1 to
7b120a5
Compare
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! this is great!
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
3 participants
No description provided.