LG-3191: one mobile page to submit them all#3994
Merged
Conversation
solipet
requested review from
aduth,
amathews-fs,
anniehirshman-gsa and
jmhooper
aduth
reviewed
Jul 30, 2020
aduth
added a commit
that referenced
this pull request
Jul 30, 2020
**Why**: To simplify future reconciliation
solipet
force-pushed
the
dprice-lg-3191-one-mobile-page-to-submit-them-all
branch
from
7645b40 to
f17bbf3
Compare
6 tasks
aduth
approved these changes
Jul 30, 2020
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I'll defer to others on design and/or more of the Rails-specific implementation. From my testing, it appears to work quite well, and doesn't conflict with the React implementation on both desktop and mobile. There's graceful fallback in JavaScript-disabled environment as well. I left a few minor comments. I note that there's quite a bit of duplication of the mobile code, though as you mention, if it's something that is likely to be temporary, I don't see it as being of much concern.
aduth
added a commit
that referenced
this pull request
Jul 31, 2020
* Add DeviceContext context
**Why**: Since the design incorporates elements which vary depending on support for rear-facing ("environment") and front-facing ("user") video capture support, we need a means to be able to make this value available to all components of the application
* Add documents introduction component
**Why**: While the introductory text is the same for desktop and mobile, on mobile devices it (1) occurs as its own standalone step and (2) includes one fewer instructions items (file size recommendation)
* Abstract PageHeading component
**Why**: To consolidate styling for page headings, in anticipation of future refactoring away from using Basscss
* Render introductory instructions common to all devices
* Align locale string naming to #3994
**Why**: To simplify future reconciliation
* Simplify DeviceContext to simple object of isMobile
**Why**: While we may need more granular detail of device-specific constraints, it's unclear as of yet how that will be implemented.
Contributor
|
Reported conflicts are from #3990. In that branch, I tried to align directly with the string keys / names you proposed here, so it's fair to err on your side: |
aduth
reviewed
Jul 31, 2020
solipet
force-pushed
the
dprice-lg-3191-one-mobile-page-to-submit-them-all
branch
from
f17bbf3 to
10b4b73
Compare
solipet
force-pushed
the
dprice-lg-3191-one-mobile-page-to-submit-them-all
branch
from
10b4b73 to
aaebfe4
Compare
This was referenced Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've redesigned the doc_auth backstop to a much simpler form, and now it is the same for the desktop and mobile flows.
I've added an undocumented flag,
document_capture_react_enabled, that if set to 'false' will skip over the React code import thus disabling the react version of the form. This was done to make it easy for development and test, but should never be set in a deployed environment (except perhaps personal).Here's a screenshot of the final result. I tried to get the margins to match the design, but it seems the design system classes don't have quite the granularity required, e.g.,
mt2is a 1 rem margin-top, whilemt3is 2 rem. If we want 1.5 rem, we would have to include custom css.The error message at the top is only included upon a failure to proof, while the "For best results" sections are always present.