Log acuant result code, if billable (LG-2495)#4001
Merged
zachmargolis merged 9 commits intomasterfrom Aug 3, 2020
Merged
Conversation
zachmargolis
commented
Aug 3, 2020
| Acuant::Responses::ResponseWithPii.new( | ||
| acuant_response: selfie_response, | ||
| pii: pii, | ||
| billed: results.result_code&.billed?, |
Contributor
Author
There was a problem hiding this comment.
@stevegsa just wanted to check my understanding on this...the only time we call the GetResults API is inside of this API where we post all 3 ---- but that's the newer flow right? Do you know which endpoint in the older flow we want to be be checking for this result code in?
Contributor
There was a problem hiding this comment.
Unfortunately it looks like somebody removed the code to add_cost on the results call.
Contributor
There was a problem hiding this comment.
Actually it looks good. Those results calls are in fetch_doc_auth_results_or_redirect_to_selfie
Contributor
Author
There was a problem hiding this comment.
OK so back_image_step needs cost info added?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.