Skip to content

LG-3177 Update gems to the new typhoeus-less versions and minor updates.#3998

Merged
amathews-fs merged 2 commits intomasterfrom
LG-3177-remove-typhoeus-amathews
Aug 3, 2020
Merged

LG-3177 Update gems to the new typhoeus-less versions and minor updates.#3998
amathews-fs merged 2 commits intomasterfrom
LG-3177-remove-typhoeus-amathews

Conversation

@amathews-fs
Copy link
Copy Markdown
Contributor

Typhoeus has been removed from all dependencies and the idp itself. We'll see what unexpected things broke with those changes.

@zachmargolis
Copy link
Copy Markdown
Contributor

Looks like switching Google Analytics backend broke some specs:

rspec ./spec/services/google_analytics_measurement_spec.rb:30 # GoogleAnalyticsMeasurement#new sends a properly formatted request

Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amathews-fs amathews-fs force-pushed the LG-3177-remove-typhoeus-amathews branch from 7d5dba1 to fe7bb9d Compare August 3, 2020 19:13
@amathews-fs amathews-fs removed the request for review from zachmargolis August 3, 2020 20:15
@amathews-fs amathews-fs merged commit bf5d1db into master Aug 3, 2020
@amathews-fs amathews-fs deleted the LG-3177-remove-typhoeus-amathews branch August 3, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants