Closed
Conversation
**Why**: The feature in question is account reactivation, this improves naming consistency
**Why**: Consistency is key. In this case, the cancel link on the forgot password page was always linking to the home page. **How**: Don't use the `shared/cancel` partial because the user will never be signing up or going through IdV if they are accessing the Forgot Password page, so we can directly link to the decorated session's `cancel_link_path` which contains the logic to determine whether it should point to the home page or the branded page.
**Why**: Testing for the link text alone is not enough. We also want to make sure the link is pointing to the right place.
Renames account recovery to account reactivation
Check href when testing links
Return to branded page consistently when canceling
**Why**: Removing references to the session will make it easier to extract VendorValidator work into a background job
Remove idv_session from VendorValidator
**Why**: Extracting this into a serializable object will make it easier to refactor these classes into background jobs.
Extract Idv::ProoferValidator#result
Use param for i18n
**Why**: We were comparing datetimes without freezing Time.zone.now, leading to flickering specs. **How**: Instead of comparing `otp_last_sent_at` with the current time, check that the current `otp_last_sent_at` is greater than the previous one.
**Why**: To enable rollout
Make otp_rate_limiter_spec more robust
**Why**: The retry and raise portion of `find_or_create_with_phone` was not tested.
**Why**: This tells the screen reader the content in this div is hidden. When the accordian is expanded, aria- hidden is changed to false, letting the screen reader know there is new content on screen.
Improve test coverage for OtpRequestsTracker
**Why** The situation As @andrewhughey had stated in 18F/identity-private#1890 (comment), here is the flow that this PR is fixing: create account (email, password, 2FA) verify identity (person info, financial info) choose to confirm address by mail send letter see profile / flash message that letter was sent sign out sign in asked for code from letter but oh no! I never got a letter choose send new letter expected: send new letter screen actual: restart identity verification **How** This PR adds logic to prevent the user from being redirected back to identity verification, sending them to the "Send another letter" confirmation screen instead, as expected. The faulty redirect was happening because the a request to send more mail was triggering the IdvSession service, which redirects to verification if verification hasn't been completed. To fix this, we added an exception that prevents that redirect if a user has mail already sent mail. For issue: 18F/identity-private#1890
**Why**: As part of backgrounding vendor proofing, it will be helpful for the IdV form objects to behave like the rest of the form objects in the app so we can extract them from the `Idv::Step` subclasses and invoke them in the controller.
Add aria-hidden to accordian content div
Return FormResponse from IdV form submission
Prevent Verify by mail flow redirect bug
Add CBP GOES production config
**Why**: Our test print had issues with unicode
Send plain ASCII attributes in verify-by-mail
**Why**: Helps with our translation pipeline **How**: Make sure keys use word characters and underscores only
Make sure i18n keys are consistent
**Why**: This will let us break submission in to two steps and into two controller actions which will further help us when we move the call to our vendors to background jobs.
Separate idv_form from Idv::Step classes
**Why**: Results back from vendor
Check in French translations
**Why**: To support a more complete localization
Set up SMS OTP for translation
**Why**: ERBs are compiled once, so they're stuck with whatever locale they are compiled in. This makes one .js with all translated keys for all locales that can be cached, and then looks up the locale from the <html lang> attribute on every page.
**Why**: For consistency with the behavior during account creation cancellation. **How**: - Add a new controller and route for signing the user out without having to go through `SamlIdpController#logout` since there is no single logout to be performed in this scenario - Replace the URL of the Cancel link to point to this new route
**Why**: For a consistently localized experience
Return to branded page when canceling sign in
Update translated JS to use locale dynamically from HTML
Add locale to URLs in mailers
**Why**: One last small refactor step before making the job async
Extract a synchronous proofing job
Use CBP TTP logo for GOES SPs
Contributor
|
For lower envs like this we can just push the SHA directly ot the |
Contributor
|
I'd like to wait to merge the latest Equifax fixes please, so we can resume testing on staging. Otherwise, we'll have to wait until the next release cycle. |
Contributor
Author
|
@zachmargolis ah! Good to know. Which environments do I need to submit a formal PR for? And yes, I can wait for the Equifax fixes to roll in @monfresh. Let me know when those are ready for deployment! |
Contributor
|
@gemfarmer PR only needed for staging |
Contributor
|
@gemfarmer All set. The equifax changes have been merged. Please close this PR, and follow the instructions here: |
Contributor
|
Also, the branch name must be based on the date of the release to production, which is July 24, not the 10th. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deploys changes made in Sprint 35 to the
qaenvironment.A lot happened this sprint. Changes include: