Remove idv_session from VendorValidator#1513
Merged
zachmargolis merged 1 commit intomasterfrom Jun 29, 2017
Merged
Conversation
zachmargolis
force-pushed
the
margolis-remove-session-from-validator
branch
2 times, most recently
from
b942368 to
aef8a02
Compare
**Why**: Removing references to the session will make it easier to extract VendorValidator work into a background job
monfresh
approved these changes
Jun 29, 2017
Contributor
monfresh
left a comment
monfresh
left a comment
There was a problem hiding this comment.
lgtm % failing spec, which is unrelated. I'll submit a PR to fix that spec. I thought I had addressed that when we worked on the OTP stuff. Perhaps when you rebased, the spec changed?
Contributor
|
PR to fix the flickering spec is here: #1514 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Removing references to the session will make it easier to
extract VendorValidator work into a background job
--
This is one of probably many PRs that will be for async requests to vendors