Make sure i18n keys are consistent#1522
Merged
zachmargolis merged 1 commit intomasterfrom Jul 3, 2017
Merged
Conversation
zachmargolis
force-pushed
the
margolis-clean-up-i18n-keys
branch
from
bccb112 to
ac2746c
Compare
jmhooper
reviewed
Jun 30, 2017
spec/i18n_spec.rb
Outdated
Contributor
There was a problem hiding this comment.
Any concerns about leading, trailing, or double underscores? \A[a-z0-9]+(_[a-z0-9]+)*\z protects against that, but is not as pretty.
Contributor
Author
There was a problem hiding this comment.
I'm OK not worrying about those cases?
The things that caused us problems in this most recent round were spaces, quotes and dashes in keys, so I just wanted to handle those. A few extra underscores seems ok for now to me.
Contributor
There was a problem hiding this comment.
Ooops, forgot the dot. Get's really ugly once you factor that in. Probs not worth it.
Contributor
|
Looks like there is a spec that needs to be updated to look for the new key name. |
zachmargolis
force-pushed
the
margolis-clean-up-i18n-keys
branch
from
568bca4 to
ecdad0e
Compare
**Why**: Helps with our translation pipeline **How**: Make sure keys use word characters and underscores only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Helps with our translation pipeline
How: Make sure keys use word characters and underscores only