Improve test coverage for OtpRequestsTracker#1516
Merged
Conversation
monfresh
force-pushed
the
mb-improve-test-coverage
branch
from
da0cd3b to
38e69b7
Compare
zachmargolis
approved these changes
Jun 29, 2017
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM one comment, not a blocker
Contributor
There was a problem hiding this comment.
Why do we need the Timecop.freeze here?
Contributor
Author
There was a problem hiding this comment.
oops. forgot to remove it.
monfresh
force-pushed
the
mb-improve-test-coverage
branch
from
38e69b7 to
fd64256
Compare
**Why**: The retry and raise portion of `find_or_create_with_phone` was not tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The retry and raise portion of
find_or_create_with_phonewas not tested.